Closed
Bug 1034633
Opened 10 years ago
Closed 10 years ago
[Messages] subtle padding issues while manipulating the subject
Categories
(Firefox OS Graveyard :: Gaia::SMS, defect)
Tracking
(blocking-b2g:2.0+, b2g-v2.0 verified, b2g-v2.1 verified)
People
(Reporter: julienw, Assigned: azasypkin)
References
Details
(Keywords: regression, Whiteboard: [p=1])
Attachments
(10 files)
14.05 KB,
image/png
|
Details | |
15.56 KB,
image/png
|
Details | |
15.28 KB,
image/png
|
Details | |
46 bytes,
text/x-github-pull-request
|
julienw
:
review+
|
Details | Review |
27.23 KB,
image/png
|
vicky
:
ui-review+
|
Details |
33.38 KB,
image/png
|
vicky
:
ui-review+
|
Details |
28.01 KB,
image/png
|
vicky
:
ui-review+
|
Details |
34.00 KB,
image/png
|
vicky
:
ui-review+
|
Details |
21.88 KB,
image/png
|
Details | |
27.74 KB,
image/png
|
Details |
See in attachments the subject + input locations.
Reporter | ||
Comment 1•10 years ago
|
||
Reporter | ||
Comment 2•10 years ago
|
||
Reporter | ||
Comment 3•10 years ago
|
||
Reporter | ||
Comment 4•10 years ago
|
||
This is especially noticeable when typing the first letter of a subject, because we very clearly see that it's moving. NI Vicky to give input about what is the correct padding.
Blocks: 1008127
Flags: needinfo?(vpg)
Comment 5•10 years ago
|
||
THis is the correct hight: https://bug1034633.bugzilla.mozilla.org/attachment.cgi?id=8451010
Flags: needinfo?(vpg)
Reporter | ||
Updated•10 years ago
|
Blocks: sms-sprint-2.0S6
Whiteboard: [p=1]
Reporter | ||
Updated•10 years ago
|
Target Milestone: --- → 2.0 S6 (18july)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → azasypkin
Status: NEW → ASSIGNED
Assignee | ||
Comment 6•10 years ago
|
||
Hey Julien, I've reduced the height of the send button a bit (so now it's the same as min-height of the message input) to get rid of the issue described in the bug. But I'm in doubt whether there is enough space now, it looks OK imho. + I'm experimenting with 'background-blend-mode' instead of separate image for the disabled state. So I need your feedback on both changes :)
Attachment #8452300 -
Flags: feedback?(felash)
Reporter | ||
Comment 7•10 years ago
|
||
Comment on attachment 8452300 [details] [review] GitHub pull request URL You should ask Victoria about this, in both DSDS and non-DSDS screen captures. If she's fine, I am too. But I suspect she won't :) For example I don't understand why there is a difference between a empty and non empty subject. This surely can be fixed differently...
Attachment #8452300 -
Flags: feedback?(felash)
Comment 8•10 years ago
|
||
This does not look like a release blocking issue, its really hard to spot. Although, if this is a simple css change we can consider uplift before July 21.
blocking-b2g: 2.0? → ---
Assignee | ||
Comment 9•10 years ago
|
||
Hey Vicky, Could you please let me know if you're OK (or not) with the top and bottom paddings for the send button. I'm asking becuase I've reduced send button height from 4.5rem to 4rem (initial height of the message input field) to simplify the fix for the issue in this bug. If you're not OK with it, I'll try to find other solution. Thanks!
Attachment #8452532 -
Flags: ui-review?(vpg)
Assignee | ||
Comment 10•10 years ago
|
||
Attachment #8452533 -
Flags: ui-review?(vpg)
Assignee | ||
Comment 11•10 years ago
|
||
Attachment #8452534 -
Flags: ui-review?(vpg)
Assignee | ||
Comment 12•10 years ago
|
||
Attachment #8452535 -
Flags: ui-review?(vpg)
Updated•10 years ago
|
Attachment #8452534 -
Flags: ui-review?(vpg) → ui-review+
Updated•10 years ago
|
Attachment #8452535 -
Flags: ui-review?(vpg) → ui-review+
Updated•10 years ago
|
Attachment #8452533 -
Flags: ui-review?(vpg) → ui-review+
Updated•10 years ago
|
Attachment #8452532 -
Flags: ui-review?(vpg) → ui-review+
Comment 13•10 years ago
|
||
(In reply to Oleg Zasypkin [:azasypkin] from comment #9) > Created attachment 8452532 [details] > Single SIM (SMS) > > Hey Vicky, > > Could you please let me know if you're OK (or not) with the top and bottom > paddings for the send button. I'm asking becuase I've reduced send button > height from 4.5rem to 4rem (initial height of the message input field) to > simplify the fix for the issue in this bug. > > If you're not OK with it, I'll try to find other solution. > > Thanks! I think it's fine
Assignee | ||
Comment 14•10 years ago
|
||
Comment on attachment 8452300 [details] [review] GitHub pull request URL (In reply to Victoria Gerchinhoren [:vicky] from comment #13) > (In reply to Oleg Zasypkin [:azasypkin] from comment #9) > > Created attachment 8452532 [details] > > Single SIM (SMS) > > > > Hey Vicky, > > > > Could you please let me know if you're OK (or not) with the top and bottom > > paddings for the send button. I'm asking becuase I've reduced send button > > height from 4.5rem to 4rem (initial height of the message input field) to > > simplify the fix for the issue in this bug. > > > > If you're not OK with it, I'll try to find other solution. > > > > Thanks! > > I think it's fine Thanks Vicky! Julien, could you please review the patch then? Thanks
Attachment #8452300 -
Flags: review?(felash)
Reporter | ||
Comment 15•10 years ago
|
||
(In reply to bhavana bajaj [:bajaj] [NOT reading Bugmail, needInfo please] from comment #8) > This does not look like a release blocking issue, its really hard to spot. Bhavana, this is really not hard to spot when you use the device (it is accordingly hard to spot with screenshots). I can't provide videos right now as I'm not in the office, but the padding change is very noticeable when you add text. Try these STR: 1. open the SMS app 2. tap the "new message" button 3. tap the "settings" button, then "add subject" 4. tap the "subject" input, wait that the keyboard appears 5. input one letter => see how it changed 6. remove that letter => it changed back I agree this is polish, but here I consider this is a regression, and that it brings a really bad feeling.
blocking-b2g: --- → 2.0?
Keywords: regression
Reporter | ||
Comment 16•10 years ago
|
||
Vicky, I'd like to be sure that you'be seen that the input's min height is changed with this patch too. Is it ok for you?
Flags: needinfo?(vpg)
Reporter | ||
Comment 17•10 years ago
|
||
Comment on attachment 8452300 [details] [review] GitHub pull request URL r=me, but please wait for Vicky needinfo before merging. If she's not ok with the min-height change we'll need something else.
Attachment #8452300 -
Flags: review?(felash) → review+
Reporter | ||
Comment 19•10 years ago
|
||
Looks like you missed the "2.0+" item ;)
blocking-b2g: 2.1+ → 2.0?
Assignee | ||
Comment 21•10 years ago
|
||
Master: https://github.com/mozilla-b2g/gaia/commit/3924f4d1d38c1359e8071316bec45eae24affee2
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
blocking-b2g: 2.0? → 2.0+
Comment 22•10 years ago
|
||
v2.0: https://github.com/mozilla-b2g/gaia/commit/4cf4fd8698578c12a7cf9a01c63a75eef8710f7e
status-b2g-v2.0:
--- → fixed
status-b2g-v2.1:
--- → fixed
Comment 23•10 years ago
|
||
According to the STR in comment#15, the issue has been verified successfully on Flame 2.0 and 2.1. See attachment: Verify_Flame2.1_1.png & Verify_Flame2.1_2.png Reproducing rate: 0/5 Flame 2.0 build: Gaia-Rev 856863962362030174bae4e03d59c3ebbc182473 Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/e40fe21e37f1 Build-ID 20141208000206 Version 32.0 Flame 2.1 build: Gaia-Rev 38e17b0219cbc50a4ad6f51101898f89e513a552 Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/8b92c4b8f59a Build-ID 20141205001201 Version 34.0
Comment 24•10 years ago
|
||
Updated•10 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•